Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Reset Password Token/Expiry on password change #1167

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Apr 7, 2020

Closes #650

Seems like a rare instance, but it makes sense to also reset the token/expiry if they are possibly set when a user changes their passphrase.

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is a non-obvious edge case, can you add a comment explaining why we're resting the the reset password fields?

@lukebp lukebp merged commit 06c66f0 into decred:master Apr 30, 2020
vibros68 pushed a commit to vibros68/politeia that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset link should expire automatically after passowrd changed
2 participants