www: Update wsDcrdata context #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff pulls the dcrdata websocket functionality out of the cms address watcher implementation and creates an abstraction that can be used to manage dcrdata websocket connections.
alexlyp
requested changes
Jun 25, 2019
| if p.pubSubDcrdata != nil && p.pubSubDcrdata.client != nil { | ||
| p.pubSubDcrdata.client.Stop() | ||
| // Shutdown all dcrdata websockets | ||
| if p.wsDcrdata != nil { |
There was a problem hiding this comment.
Do we not need to verify that p.wsDcrdata.client is not nil here?
There was a problem hiding this comment.
No because wsDcrdata is initialized using the function newWSDcrdata, which ensures that the client is setup correctly. If it's being initialized without using newWSDcrdata then its being initialized incorrectly.
There was a problem hiding this comment.
Cool thanks for clarifying. Looks good.
alexlyp
approved these changes
Jun 25, 2019
This was referenced Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff pulls the dcrdata websocket functionality out of the cms address watcher implementation and creates a general abstraction for managing dcrdata websocket connections.
It also updates the cms address watcher naming convention to make a distinction between cms address watching and the pi paywall functionality, which will both use dcrdata websocket subscriptions for address events.