-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Own comment votes displayed incorrectly #2375
Comments
This is related to #2374 and I'll fix both. |
Also related, when you upvote/downvote a comment it briefly flashes the not allowed symbol while its sending the request. This seems unnecesary. UX could be improved by removing it. |
@tiagoalvesdulce I can still reproduce this. Is it pending deployment or is it a regression? |
@xaur this fix is up on test-proposals and will hopefully be deployed to mainnet in the next few days. It's dependent on dhill's schedule. |
Thanks, looks good on test-proposals. |
After the recent deployment I can see all upvotes that I remember to have casted. It also works for Pi proposal (iirc there was some bug with comment vote display on props that had finished voting). Thanks! |
Scenario 1: Open proposal page and upvote a comment that I did not upvote before.
Vote buttons change from
to
i.e. the count is incremented correctly but the thumbs up icon does not change to solid black.
If I click again the count returns back to 2 as expected.
Scenario 2: Open proposal page and upvote a comment that I already upvoted.
Upon opening, the counter is at
3
as expected (it includes my upvote). But if I click it it goes to4
If I refresh the page it changes back to
2
, removing my upvote.The text was updated successfully, but these errors were encountered: