Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own comment votes displayed incorrectly #2375

Closed
xaur opened this issue May 6, 2021 · 6 comments · Fixed by #2384
Closed

Own comment votes displayed incorrectly #2375

xaur opened this issue May 6, 2021 · 6 comments · Fixed by #2384
Assignees

Comments

@xaur
Copy link

xaur commented May 6, 2021

Scenario 1: Open proposal page and upvote a comment that I did not upvote before.

Vote buttons change from

1

to

2

i.e. the count is incremented correctly but the thumbs up icon does not change to solid black.

If I click again the count returns back to 2 as expected.

Scenario 2: Open proposal page and upvote a comment that I already upvoted.

Upon opening, the counter is at 3 as expected (it includes my upvote). But if I click it it goes to 4

3

If I refresh the page it changes back to 2, removing my upvote.

@tiagoalvesdulce
Copy link
Member

This is related to #2374 and I'll fix both.

@tiagoalvesdulce tiagoalvesdulce self-assigned this May 6, 2021
@lukebp
Copy link
Member

lukebp commented May 6, 2021

Also related, when you upvote/downvote a comment it briefly flashes the not allowed symbol while its sending the request. This seems unnecesary. UX could be improved by removing it.

@xaur
Copy link
Author

xaur commented Jun 18, 2021

@tiagoalvesdulce I can still reproduce this. Is it pending deployment or is it a regression?

@lukebp
Copy link
Member

lukebp commented Jun 18, 2021

@xaur this fix is up on test-proposals and will hopefully be deployed to mainnet in the next few days. It's dependent on dhill's schedule.

@xaur
Copy link
Author

xaur commented Jun 19, 2021

Thanks, looks good on test-proposals.

@xaur
Copy link
Author

xaur commented Jun 22, 2021

After the recent deployment I can see all upvotes that I remember to have casted. It also works for Pi proposal (iirc there was some bug with comment vote display on props that had finished voting). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants