Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Proposal Edit mock structure. #2645

Closed
victorgcramos opened this issue Nov 4, 2021 · 1 comment · Fixed by #2692
Closed

e2e: Proposal Edit mock structure. #2645

victorgcramos opened this issue Nov 4, 2021 · 1 comment · Fixed by #2692

Comments

@victorgcramos
Copy link
Member

Part of #2642.

Proposal Edit tests are still using the online api approach. We need to migrate it to the new mock structure introduced by (#2624).

We currently don't need new test suites, the main focus here is to first migrate and then code more tests using this new structure.

Tips and Tricks

  • Only mock requests related to Proposal Edit page
  • Run only edit test file: yarn cy:run -- --spec "cypress/e2e/proposal/edit.js"
  • Setup the API environment for all possible routes reached by the tests suite using a beforeEach statement
  • Check on politeiawww's logs to check if all requests were mocked properly
  • Use proposal/list.js tests as reference
@victorgcramos victorgcramos changed the title e2e: Proposal Edit mock structure e2e: Proposal Edit mock structure. Nov 4, 2021
@vibros68
Copy link
Contributor

vibros68 commented Dec 8, 2021

I am on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants