Allow short token URLs #1962
Merged
Allow short token URLs #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiagoalvesdulce Intended mate, BE edit route need the full token so I kept it as is in that case - when edit is done I do use the short token when redirecting the user to proposal's details page |
| @@ -27,19 +26,6 @@ export const getStatusBarData = (voteSummary) => { | |||
| .sort((a) => (a.label === "yes" ? -1 : 1)); | |||
| }; | |||
|
|
|||
| export const getProposalUrl = (token, javascriptEnabled) => | |||
There was a problem hiding this comment.
Is there any specific reason for removing this piece of code?
There was a problem hiding this comment.
hehe sure, it's just a cleanup at some point we created useProposalURLs hook and it uses the same functions which are defined in https://github.com/amassarwi/politeiagui/blob/tokenPrefix/src/containers/Proposal/helpers.js#L225-L236
tiagoalvesdulce
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff allows users to use short proposal's token in URLs - first 7 chars of original 64 chars hex.
Solution description
useProposalhook to fetch voteSummary only when full token is fetched and stored in redux store.makeGetProposalByTokenselector to try find the stored proposal by using the 7 chars prefix instead of full length token.useProposalURLshook to use prefix instead of full token to struct proposal URLs.ProposalFormsubmit handler to use short token when navigating to proposal details after successful edit/create.Dependencies
Closes #1939