Prevent comments and proposals submission when anchoring #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Hey @tiagoalvesdulce thanks for the PR! LGTM! Just left one inline observation!
src/helpers.js
Outdated
| return timeDiffMinutes >= 0 && timeDiffMinutes < anchoringDuration; | ||
| }; | ||
|
|
||
| isAnchoring(); |
There was a problem hiding this comment.
Why are you calling this here? Any specific reason? If so, could you please leave a comment here referencing the method you are using? Thanks a lot!
There was a problem hiding this comment.
It was for testing purposes and I forgot to remove it. Thanks for noticing :)
amass01
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
isAnchoringfunction and prevents proposals and comments submission during a given time (default to 06:58 UTC and 10 minutes).Solution description
My solution is a simple diff between the current time and the target time and check if its greater than 0 and less than the set duration time.
Depends on decred/politeia#1205