[CMS] feat: add proposal spending summary and details #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoalvesdulce
changed the title
alexlyp
approved these changes
Jul 7, 2020
amass01
approved these changes
Jul 7, 2020
| }; | ||
|
|
||
| const getDetailsData = (invoices) => { | ||
| const formattedData = |
There was a problem hiding this comment.
This function can be a one liner :)
| proposalDetails: null | ||
| }; | ||
|
|
||
| // const normalizeProposalBilling = (proposals) => |
amass01
reviewed
Jul 7, 2020
| // }, {}); | ||
|
|
||
| const proposalBilling = (state = DEFAULT_STATE, action) => { | ||
| return action.error |
There was a problem hiding this comment.
Also here no need for the return I guess
|
Needs a rebase, but decred/politeia#1224 has been merged to final testing/review may occur. |
tiagoalvesdulce
force-pushed
the
proposalSpending
branch
from
2949f08
to
993c0fe
Compare
alexlyp
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2019
Solution description
I added two new routes:
/admin/proposalsbillingand/admin/proposalsbilling/:tokenthat consume data fromspendingsummaryandspendingdetailsendpoints. Created a new normalized redux state branch calledproposalBillingto be the single source of truth for this data. This PR is a WIP and will be imrpoved before merged.Dependencies
Depends on decred/politeia#1224
UI Changes Screenshot
Summary
Details