-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: normalize redux state with short tokens #2365
Conversation
We should wait for e2e to be ready before getting this in since it touches a lot of sensitive parts of the app |
Hey guys, this is ready for a review. Please check the state tree to see if we are indeed consistent about short token use on all of the trees :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Couldn't find any error with a quick test. I'll wait #2383 to merge this so we can be more confident it doesn't introduce issues we couldn't catch.
Closed by mistake |
8f27636
to
6c3056c
Compare
@tiagoalvesdulce e2e already being very useful. caught some minor bug that could otherwise pass unoticed on a review 👍 :) this PR is ready |
Nice! Code is looking good, just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @tiagoalvesdulce, nice catch. Will be fixing this asap |
…oken helper for increased consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This diff normalizes our entire redux state to use short tokens instead of full tokens, resolving various bugs that may happen when the app expects one token form, and receives another.
closes #2353