fix: Initial Load Flickering. #2395
Conversation
| ); | ||
| } else { | ||
| dispatch( | ||
| act.UPDATE_USER_PAYWALL_STATUS({ |
There was a problem hiding this comment.
we rely on this action to determine if the user has paid or not
| @@ -17,7 +17,8 @@ const PaywallMessage = ({ wrapper, ...props }) => { | |||
| title: "Complete your registration", | |||
| onClose: handleCloseModal | |||
| }); | |||
| const showMessage = !!currentUserEmail && !isPaid; | |||
| const showMessage = !!currentUserEmail && isPaid === false && isPaid !== null; | |||
There was a problem hiding this comment.
If isPaid is null we don't want to show the message as this means the isPaid info not available yet.
| @@ -29,16 +28,13 @@ const Loader = ({ children }) => { | |||
| try { | |||
| const apiInfo = await onRequestApiInfo(false); | |||
| setApiInfo(apiInfo); | |||
| if (apiInfo.activeusersession) { | |||
There was a problem hiding this comment.
we have the same check already in onRequestApiInfo.
|
|
||
| return update(["byUserID", userid], (paywall) => ({ | ||
| ...paywall, | ||
| isPaid: paywalladdress === "" |
There was a problem hiding this comment.
now we update isPaid only when on UPDATE_USER_PAYWALL_STATUS action, as the backend returns explicit
haspaid field.
There was a problem hiding this comment.
to elaborate on this:
this was an issue for paid users; isPaid: paywalladdress === "" => resulted in isPaid = false this why the paywall message was visible for few moments until UPDATE_USER_PAYWALL_STATUS was dispatched with status paid which switched isPaid to true and only then the paywall message disappeared.
amass01
force-pushed
the
initialflickering
branch
from
318e6aa
to
42edcd3
Compare
|
@tiagoalvesdulce Thanks for the screen record, I would like to fix that in this PR, the paywall shouldn't flicker like that, |
|
OK, I'll create an issue. |
This improves the initial load flickering, before this the paywall message was displayed for some time and then
when the paywall info received from backend the message was gone.
This commit changes this behavior to hide the message by default and only after receiving from the backend that user
hasn't paid the message would show up.
Closes #2395.