e2e proposal edit mock structure #2692
Conversation
There was a problem hiding this comment.
Hey mate, thanks for the PR. Noticed that your first test case hits the /comments/v1/comments on the backend. Also, left some inline comments to improve test readability and flow.
Notice that we already use middlewares for making request aliases, so you can use middleware's alias instead of cy.route().
teste2e/cypress/e2e/proposal/edit.js
Outdated
| cy.findByTestId(/record-edit-button/i).click(); | ||
| cy.findByRole("button", { name: /submit/i }).should("be.disabled"); | ||
| cy.findByTestId("text-area").type(newDescription); | ||
| cy.route("POST", "/api/records/v1/edit").as("editProposal"); |
There was a problem hiding this comment.
You can remove it, since we are already using middlewares.
teste2e/cypress/support/core/api.js
Outdated
| const { name, description, startDate, endDate, amount, domain } = | ||
| buildProposal(); | ||
| const { files } = makeProposal({ | ||
| name, | ||
| markdown: description, | ||
| startdate: startDate, | ||
| enddate: endDate, | ||
| amount, | ||
| domain | ||
| }); |
There was a problem hiding this comment.
Remember, records and proposals are different concepts. This should handle records, not proposals. You should pass files as a test parameter, if you need it.
| return { record }; | ||
| } | ||
|
|
||
| export function editRecordReply({ |
There was a problem hiding this comment.
Edit record should not return version 1.
There was a problem hiding this comment.
I think this comment wasn't addressed.
There was a problem hiding this comment.
It is addressed. If we do not pass the version param. The function will generate a randomly greater than 1 value. The code is here:
const version = recordVersion || faker.datatype.number(6) + 1;
| @@ -97,7 +97,7 @@ export function Record({ | |||
| const token = recordToken || Token(); | |||
| const status = recordStatus || faker.datatype.number(3) + 1; | |||
| const state = recordState || faker.datatype.number(1) + 1; | |||
| const user = author instanceof User || new User(); | |||
| const user = author || new User(); | |||
There was a problem hiding this comment.
why? The instanceof comparison is the whole purpose of using classes on data generators 😁 . I guess it's better if we take advantage of this feature.
There was a problem hiding this comment.
instanceof work on the normal function. But after pass via cy middleware function, it is not working right and the result is always be false
| export function meReply({ testParams: { userType, verifyIdentity } }) { | ||
| const user = userByType(userType); | ||
| export function meReply({ testParams: { userType, verifyIdentity, user } }) { | ||
| if (!user) { |
There was a problem hiding this comment.
This is where you can use the instanceof operator, where you can assert if user has User props.
teste2e/cypress/e2e/proposal/edit.js
Outdated
| cy.intercept("/api/records/v1/details").as("details"); | ||
| cy.intercept("/api/pi/v1/summaries").as("summaries"); |
teste2e/cypress/support/core/api.js
Outdated
| import { makeProposal } from "../../utils"; | ||
| import { buildProposal } from "../generate"; |
teste2e/cypress/e2e/proposal/edit.js
Outdated
| cy.findByTestId(/record-edit-button/i).should("not.exist"); | ||
| } | ||
| ); | ||
| it("shouldn't be editable a proposal if not be the owner", () => { |
There was a problem hiding this comment.
| it("shouldn't be editable a proposal if not be the owner", () => { | |
| it("shouldn't allow editing if user is not the proposal owner", () => { |
teste2e/cypress/e2e/proposal/edit.js
Outdated
|
|
||
| beforeEach(() => { | ||
| describe("Proposal Edit", () => { | ||
| it("should be editable a public proposal as a proposal owner", () => { |
There was a problem hiding this comment.
| it("should be editable a public proposal as a proposal owner", () => { | |
| it("should allow proposal owner to edit its own public proposal", () => { |
teste2e/cypress/e2e/proposal/edit.js
Outdated
| it("shouldn't be editable without making any changes", () => { | ||
| cy.server(); | ||
| const user = userByType(USER_TYPE_ADMIN); | ||
| cy.log(user, user instanceof User); |
There was a problem hiding this comment.
LGTM! Just need to fix https://github.com/decred/politeiagui/pull/2692/files#r770595023 and we should be good to go! Good job!
|
Thank you @victorgcramos |
| return { record }; | ||
| } | ||
|
|
||
| export function editRecordReply({ |
There was a problem hiding this comment.
I think this comment wasn't addressed.
Closes #2645
This diff implement mock data for edit proposal page. So the teste2e
will not submit to the server. This new mock structure introduced by
#2624.