multi: Add Navbar #2763
Merged
multi: Add Navbar #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoalvesdulce
requested changes
May 11, 2022
There was a problem hiding this comment.
- The Politeia Logo should be clickable and redirect to the
Home. - Where is the
.splashclass used? - How would I add a hamburger menu to the nav when the children on the right are wrapped?
- Your
React.Children.mapsonNavbarare a bit confusing. Can you add comments or think about alternative implementations? - A little observation: If we are always importing
Column as Colfrompi-ui, why not exportingColinstead ofColumn? - The navbar is looking a little bit different than the actual prod app. See:
Prod:
This PR:
Background color, font color and spacing are different. Spacing is pretty minimal and if it looks good I'm OK but we should match background color and font color.
- Responsive version can be improved a lot comparing to the prod version.
|
@tiagoalvesdulce sorry, PR still WIP. Forgot to make it a draft. My bad. Thanks for the feedback, though! I'll keep that in mind! |
victorgcramos
force-pushed
the
common-ui/navbar
branch
from
13674f6
to
efcb2ff
Compare
|
Navbar for small screens:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Navbar component implementation on common-ui,
and adds its on our politeia app-shell.
common-ui package:
politeia app:
UI Preview
Light Theme:
Dark Theme:
