Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Proposal Edit and Raw pages #2892

Merged
merged 18 commits into from
Jan 26, 2023

Conversation

victorgcramos
Copy link
Member

This PR adds the Proposal Edit and Proposal Raw pages.

Part of #2875

While implementing this, I noticed that the logic used to fetch proposal
details, on Details (record/:token) page, was being affected by the
proposal details fetch on Edit (record/:token/edit) page. Since we have
already fetched it on another page, other listeners such as voteSummaries,
comments, piSummaries, weren't triggered.

One way to quick fix that was to force a request on every page load on
both details and edit pages. This, of course isn't a correct design in terms
of cache and navigation delays, but since it's out of this PR scope, I
decided to go for this quick fix.

  • Proposal Edit page: /record/:token/edit,
  • Proposal Raw page: /record/:token/raw.

@victorgcramos victorgcramos mentioned this pull request Jan 23, 2023
14 tasks
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raw page shouldn't be stylized.

How it is:
Screen Shot 2023-01-26 at 17 06 18

How it should be (matching production):
Screen Shot 2023-01-26 at 17 06 35
:

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit 5ecd6f5 into decred:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants