Feature/highlight new comments #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
changed the title
victorgcramos
changed the title
|
Fixes #732 |
fernandoabolafio
suggested changes
Nov 21, 2018
There was a problem hiding this comment.
There are a few things I noticed so far while testing:
- Click to a proposal and leave the route by clicking "back" in the browser, the componentWillUnmount isn't called, thus the access time isn't logged. Maybe move it to didMount or right after getting the last accesstime?
- Every new comment I make after opening a route is marked as new. The comments written by the current user shouldn't be highlighted. The motivation of this feature is to help the user to find comments he may not have seen yet.
Also, every time I make a new comment it request the accesstime route, It doesn't look correct.
tiagoalvesdulce
requested changes
Nov 22, 2018
tiagoalvesdulce
requested changes
Nov 24, 2018
src/components/snew/ThingComment.js
Outdated
| @@ -74,6 +74,7 @@ class ThingComment extends React.PureComponent { | |||
| ...props | |||
| } = this.props; | |||
| const isProposalAbandoned = proposalStatus === PROPOSAL_STATUS_ABANDONED; | |||
| console.log(lastVisit); | |||
fernandoabolafio
approved these changes
Nov 26, 2018
tiagoalvesdulce
approved these changes
Nov 28, 2018
- add request handle when logging out - fix proposal access time handler on react lifecycle - remove SubmitPage log - remove componentWillMount - route refactor - remove console logs - change requests according to new structure on politeia - remove logs upgrade snew-classic-ui on yarn.lock add user access time handler according to the new schema
tiagoalvesdulce
requested changes
Dec 1, 2018
|
This happens because the accesstime is set only when the proposal is fetched. This was discussed on Slack and I was told that this was the best way to deal with the situation, since I was not allowed to set the accesstime on a new request. |
|
LGTM |
tiagoalvesdulce
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.