Tests: first pass at improving coverage #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Jan 1, 2020
|
Thanks. I implemented all the changes requested in the pre-review, coverage is back to 72%. Although there's more work to do, this PR is fairly large and ready for actual review and merge. It's also OK for it to wait until the other large PRs in the pipeline are in. |
Closed
rodrigondec
reviewed
Jan 9, 2020
Merged
rodrigondec
approved these changes
Jan 11, 2020
|
#42 is merged. Sorry for the messy rebase. |
|
Rebased again, fixed all conflicts, ready for re-review. |
buck54321
requested changes
Jan 15, 2020
- added a .coveragerc config file; - changed a number of exceptions to classes ignored in the config file; - added and extended several tests; - various small improvements.
- more Exceptions converted into AssertionErrors; - added more tests.
buck54321
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at improving test coverage. Part of #38.
I added a
.coveragercconfig file which, among other things, excludes the test files themselves from coverage. This brought the overall coverage down from a theoretical 74% to a more realistic 70%.It also excludes lines raising several errors:
AssertionError,NotImplementedError,CrazyKeyErrorandParameterRangeError. I then changed a number of exceptions toAssertionErrorandNotImplementedError, let me know if this approach makes sense.I manually excluded some minor methods from coverage with the
nocovercomment.I also added and extended several tests, which also increased coverage. It currently stands at 71%.
Here is the command I'm using (it needs the
pytest-covplugin), run from the directory above the repo:UPDATE 1: more
Exceptions converted intoAssertionErrors, added more tests. Coverage is now at 72%.UPDATE 2: split
test_pydecred.pyintotest_calc.py,text_txscript.pyandtest_vsp.py.text_txscript.pyis quite large already, no reason to group unrelated tests with it.UPDATE 3: replaced all
Unimplementederrors inwallet/api.pywith the built-inNotImplementedError, and removed theUnimplementedclass itself. Coverage is now at 73%.