Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: store fee xpub in database #66

Closed
jholdstock opened this issue May 26, 2020 · 0 comments · Fixed by #97
Closed

Idea: store fee xpub in database #66

jholdstock opened this issue May 26, 2020 · 0 comments · Fixed by #97

Comments

@jholdstock
Copy link
Member

Currently dcrvsp is loading a fee xpub from config every time it starts. I have two issues with this:

  • If the operator changes the value set in config, the behaviour is undefined.
  • It adds an extra step to recovering a backup. The operator has to put their backed up database in place, and also ensure the correct xpub is set in config.

Alternative: Accept an xpub once, first time a VSP is started, probably via CLI flag. Store this in the database. This fixes both issues above. Comparable to having to init dcrwallet the first time it is run, using --create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant