Improve admin screen aesthetics. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the voting wallet status and the ticket search were stacked on top of eachother, making the page very long and awkward to navigate. This introduces tabbed navigation which allows just one to be displayed at a time.
Wallet Status Before
Wallet Status After
|
Ticket Info Before
Ticket Info After
|
Tabs in action
|
jholdstock
changed the title
dnldd
reviewed
May 28, 2021
| var indented bytes.Buffer | ||
| err := json.Indent(&indented, []byte(input), "<br/>", " ") | ||
| if err != nil { | ||
| log.Errorf("Failed to indent JSON: %w", err) |
There was a problem hiding this comment.
Avoid capitalizing the error string here.
There was a problem hiding this comment.
This is just a logging statement which will be printed in isolation, thus the caps. This matches the rest of the log statements in the project. Error strings on the other hand are lower-cased because they are usually printed with some proceeding context.
dnldd
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to Admin screen aesthetics:
Improvements to voting wallet status table:
Improve ticket info table:
Note to reviewers - send me a DM and I will give you the admin password + a ticket hash so you can test this out on https://testnet-vsp.jholdstock.uk