Consider DCP0012 in VSP fee calculations. #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Sep 15, 2023
davecgh
approved these changes
Sep 15, 2023
| @@ -37,6 +40,9 @@ var MainNet = Network{ | |||
| // DCP0010Height on mainnet is block | |||
| // 00000000000000002f4c6aaf0e9cb4d5a74c238d9bf8b8909e2372776c7c214c. | |||
| DCP0010Height: 657280, | |||
| // DCP0012Height on mainnet is block | |||
| // 071683030010299ab13f139df59dc98d637957b766e47f8da6dd5ac762f1e8c7. | |||
There was a problem hiding this comment.
Confirmed.
$ dcrctl getblockchaininfo | jq -c '.deployments.changesubsidysplitr2 | {status,since}'
{"status":"active","since":794368}
$ dcrctl getblockchaininfo | jq '.deployments.changesubsidysplitr2.since' | dcrctl getblockhash -
071683030010299ab13f139df59dc98d637957b766e47f8da6dd5ac762f1e8c7| @@ -51,6 +57,9 @@ var TestNet3 = Network{ | |||
| // DCP0010Height on testnet3 is block | |||
| // 000000000000c7fd75f2234bbff6bb81de3a9ebbd2fdd383ae3dbc6205ffe4ff. | |||
| DCP0010Height: 877728, | |||
| // DCP0012Height on testnet3 is block | |||
| // c7da7b548a2a9463dc97adb48433c4ffff18c3873f7e2ae99338a990dae039f0. | |||
There was a problem hiding this comment.
Confirmed
$ dcrctl --testnet getblockchaininfo | jq -c '.deployments.changesubsidysplitr2 | {status,since}'
{"status":"active","since":1170048}
$ dcrctl --testnet getblockchaininfo | jq '.deployments.changesubsidysplitr2.since' | dcrctl --testnet getblockhash -
c7da7b548a2a9463dc97adb48433c4ffff18c3873f7e2ae99338a990dae039f0
The activation heights for DCP0012 are known for mainnet and testnet so they can be hard-coded.
Upgrade the dcrwallet dependency to pick up the new version of txrules.StakePoolTicketFee which considers the status of DCP0012 in its fee calculation.
jholdstock
force-pushed
the
internal2
branch
from
f974469
to
a75c6b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the dcrwallet dependency to pick up the new version of txrules.StakePoolTicketFee which considers the status of DCP0012 in its fee calculation.