Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localhost-wait #25

Closed
ineiti opened this issue Oct 7, 2015 · 4 comments
Closed

Localhost-wait #25

ineiti opened this issue Oct 7, 2015 · 4 comments

Comments

@ineiti
Copy link
Member

ineiti commented Oct 7, 2015

It doesn't wait for the end of the experiment before quitting to the command line...
liamsi added a commit to liamsi/cothority that referenced this issue Oct 7, 2015
@liamsi
quick fix for issue dedis#25
16eb2cd 
only 'err' with "unable to get good data" if the platform is deterlab
(on localhost the monitor won't start and returns empty RunStats{})
@liamsi
Copy link
Member

liamsi commented Oct 7, 2015

I wanted to try the localhost simulation and stumbled upon this issue, too. The monitor only starts (and returns a valid ResultSet) in case the app is run in "deterlab mode", but RunTest() returns before the end of the experiments in case it got empty/invalid ResultSet. The other changes are 'go fmt'/'go lint' changes.
I'll open a PR. Feel free to merge or ignore it, if you have other or better plans.

@liamsi liamsi mentioned this issue Oct 7, 2015
Merged
@ineiti
Copy link
Member Author

ineiti commented Oct 8, 2015

The long-term fix is to enable monitoring localhost, too. But that is further down the path... So I'll just merge this one. Thanks!

ineiti added a commit that referenced this issue Oct 8, 2015
@ineiti
Merge pull request #28 from Liamsi/development
cb5337d 
closes #25 as a quick fix - but as this will have to be rewritten anyway, I accept it.
@bford
Copy link

bford commented Oct 8, 2015

Thanks for jumping right in, Ismail, and welcome to the team!

@liamsi
Copy link
Member

liamsi commented Oct 9, 2015

Thanks for the warm welcome, Bryan. Can't wait for December :-)
And thanks for merging, Linus!

On Thu, Oct 8, 2015 at 8:23 AM, Bryan Ford notifications@github.com wrote:

Thanks for jumping right in, Ismail, and welcome to the team!

—
Reply to this email directly or view it on GitHub
#25 (comment).

@ineiti ineiti mentioned this issue Oct 9, 2015
Merged
@ineiti ineiti closed this as completed Oct 9, 2015
jeffallen pushed a commit that referenced this issue Jun 6, 2018
@kc1212
Merge pull request #25 from dedis/proof_12
70e68b4 
Adding a proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bford @ineiti @liamsi