Fix localhost monitor return #33
Conversation
| @@ -190,6 +207,9 @@ func (d *Localhost) Stop() error { | |||
| if err != nil { | |||
| dbg.Lvl3("Error stopping localhost", err) | |||
| } | |||
|
|
|||
| // Wait for eventual connections to clean up | |||
| time.Sleep(time.Second) | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
There is no need for both Wait() + Stop() since basically they do the same thing, one is blocking whereas the other is not.
We could somehow use a Wait() for regular "stops" of the platform and a Clean / Cleanup () for killing everything the hardway (the way Stop() is done right now), when a process can not finish after a certain timeout.
Another possiblity is to transform Wait() to take a timeout. If the timeout is passed, then Wait() kills the processes and return back to the caller. That way, both functionalities are present and there is no one more method to the interface.
|
Looks good to me - comments? |
|
Looks fine for me. There are still some issues regarding the "if platform == "deterlab" " but that kind of thing will have to be resolved in the future and is not the main concern here. |
|
Sounds good. (And for platform/testbed-related stuff don't feel like you need to get my sign-off before merging; just the two of you [Linus & Nicolas]) |
Fix localhost monitor return. Merge reviewed and accepted.
This PR allows verification of darcs when the signature path is empty, but there exists a digest of the signature path. The server, given an appropriate callbacks to find darcs, is able to find the missing path and use that for the verification. This is only the first step, more improvements are planned in the future, which we describe in #33.
OK, this is the correct fix for #31. I added a new method to the platform.Platform interface,
Waitwhich will wait for any started processes to quit.Startis non-blocking, so we can start an eventual monitor.There were some issues with
proto/signwith regard to correctly quit the signing. Now there is aCloseAllmessage in the handling of the messages which starts from the root-node and propagates to all children nodes.