bcadmin: updates the link command #1946
Conversation
- And fixes a bug where the wrong path is printed
This update refactors the argument name and allows anyone to link to a roster given a darc (--darc) and an identity (--identity). This will create or update a config file that will be set as the BC envvar except if "--silent" is given. It also add a new `bcadmin info` that prints information about the current BC config used.
| if err != nil { | ||
| return errors.New("invalid darc stored in byzcoin: " + err.Error()) | ||
| } | ||
| } | ||
|
|
||
| identity := cothority.Suite.Point() |
There was a problem hiding this comment.
So the default identity will always be the null point ? Does it make sense ? And even if it was randomly generated, you wouldn't have the private key associated with it meaning you cannot sign anything. Is there an interest in generating such config ? Same question for the empty darc.
There was a problem hiding this comment.
Good questions ! Note that this is the original behaviour.
I found it strange too, but after all I decided to trust the original author...
There was a problem hiding this comment.
@ineiti Do you remember the reason of this ?
There was a problem hiding this comment.
yes, the naming is not good (problem #1 in programming). It's not the default, but probably empty would be better.
It's useful if you want to interact with a byzcoin but don't have a private key associated with a darc. This way you still can link with a chain and get the latest blocks or other statistics.
There was a problem hiding this comment.
I wonder if we should enforce the identity and darc parameters and have a --passive or a better name that indicates you only want to interact with the chain. In any case it would nice to have better comments on this as we were two to be confused about it.
There was a problem hiding this comment.
I updated the comments.
This would set $BC on the forked process, but not the intended one.
This update refactors the argument name of
bcadmin linkand allows anyone to link to a roster given a darc (--darc) and an identity (--identity). This will create or update a config filethat will be set as the BC env var, except if--silentis given.It also adds a new
bcadmin infothat prints information about the current BC config used.Related to #1924
Fixes #1929