Adds release actions for web apps #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nkcr
commented
Nov 28, 2022
nkcr
commented
- adds instructions to build and run the web frontend/backend
nkcr
added
documentation
Pull Request Test Coverage Report for Build 3590775940
💛 - Coveralls |
nkcr
force-pushed
the
update-release-action
branch
2 times, most recently
from
bd2a932
to
309fd54
Compare
- adds instructions to build and run the web frontend/backend
nkcr
force-pushed
the
update-release-action
branch
from
309fd54
to
e8db46e
Compare
|
I've created an alpha release to check the result. Sweet! |
pierluca
reviewed
Nov 30, 2022
Comment on lines
+63
to
+67
| echo ::set-output name=version::$(echo ${GITHUB_REF/refs\/tags\//}) | ||
| echo ::set-output name=version_file::web-backend-$(echo ${GITHUB_REF/refs\/tags\//} | tr . _) | ||
| echo "::set-output name=shortsha::$(git rev-parse --short ${GITHUB_SHA})" | ||
| echo "::set-output name=buildurl::${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/commit/${GITHUB_SHA}" | ||
| echo "::set-output name=date::$(date +'%d/%m/%y %H:%M')" |
There was a problem hiding this comment.
I'm very confused by this block of code 🤔
There was a problem hiding this comment.
it declares variables that are subsequently available for the next steps, using the step id, e.g. {{ steps.get_version.version }}.
Comment on lines
-15
to
-19
| "FRONT_END_URL" : "<url of the current site, this is used for the tequila callback>", | ||
| "DELA_NODE_URL" : "<url of the dela node>", | ||
| "SESSION_SECRET" : "<session secret>", | ||
| "PUBLIC_KEY" : "<public key>", | ||
| "PRIVATE_KEY" : "<private key>" |
There was a problem hiding this comment.
is this documentation about the different fields found in config.env.template ?
Co-authored-by: pierluca <pierluca@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
pierluca
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.