Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt variable name buff formidbuf formidbuff formid not consistent #214 #259

Conversation

mamine2207
Copy link
Contributor

@mamine2207 mamine2207 commented Dec 26, 2022

Renaming variables for consistency and readability

Fixes #214

@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.8% 53.8% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3780679255

  • 7 of 13 (53.85%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 56.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proxy/shuffle.go 0 2 0.0%
proxy/election.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 3 87.21%
Totals Coverage Status
Change from base Build 3765718917: -0.05%
Covered Lines: 3269
Relevant Lines: 5758

💛 - Coveralls

@mamine2207 mamine2207 self-assigned this Dec 28, 2022
contracts/evoting/evoting.go Outdated Show resolved Hide resolved
@pierluca pierluca merged commit c4e91e7 into main Aug 9, 2023
11 of 12 checks passed
@pierluca pierluca deleted the 214-technical-debt-variable-name-buff-formidbuf-formidbuff-formid-not-consistent branch August 9, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical Debt - variable name "buff, formIDBuf, formIDBuff, formID" not consistent
4 participants