Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.21 + set go version in CI #525

Closed
wants to merge 3 commits into from
Closed

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented May 23, 2024

Closes #522

@K1li4nL K1li4nL linked an issue May 23, 2024 that may be closed by this pull request
@ineiti
Copy link
Member

ineiti commented May 23, 2024

Now you see that you have to update a lot of go-versions in the test_on_pr :) This is one of the reasons I prefer the matrix thingie...

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
37.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@K1li4nL
Copy link
Contributor Author

K1li4nL commented May 23, 2024

Now you see that you have to update a lot of go-versions in the test_on_pr :) This is one of the reasons I prefer the matrix thingie...

You want to test for both go 1.21 and 1.22 ? I added a variable for each workflow, this reduces the amount of changes needed, but it doesn't seem to be what you expect

@ineiti
Copy link
Member

ineiti commented May 24, 2024

You want to test for both go 1.21 and 1.22 ? I added a variable for each workflow, this reduces the amount of changes needed, but it doesn't seem to be what you expect

Adding a variable is good, I think using a matrix is even better - see my comment in #502 (comment) . I added another 'dimension' to the matrix in https://github.com/ineiti/test_ubuntu_32bits/blob/main/.github/workflows/test.yaml and now use exclude to not test the windows-32bit entries. If you look a the action you can see that it iterates through windows only for 64-bit, and for the ubuntu it does both 64-bit and 32-bit. Plus both golang versions.

You still only have to write the golang-versions once, and all the rest in test_on_push.yml is much shorter.

@AnomalRoil
Copy link
Contributor

Why Go 1.21 and not Go 1.22 or Go 1.18 ?

@K1li4nL
Copy link
Contributor Author

K1li4nL commented May 24, 2024

done in #526

@K1li4nL K1li4nL closed this May 24, 2024
@K1li4nL K1li4nL deleted the update-go-deps branch May 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use specific go versions in workflows and go.mo
3 participants