Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific go versions in workflows and go.mo #522

Closed
ineiti opened this issue May 22, 2024 · 1 comment · Fixed by #526
Closed

Use specific go versions in workflows and go.mo #522

ineiti opened this issue May 22, 2024 · 1 comment · Fixed by #526
Assignees

Comments

@ineiti
Copy link
Member

ineiti commented May 22, 2024

The current workflows all have the following:

      - name: Set up Go ^1.20
        uses: actions/setup-go@v3
        with:
          go-version: ^1.20

Or version 1.13. But this will always install the latest version of go, as of May 2024 this is 1.22.

I propose to choose an explicit go version, even though it needs to be updated from time to time. And then sync this with the version in go.mod, which currently is at 1.13...

For the cothority, we tested the two latest go versions with a matrix, which would be 1.21 and 1.22 here. And put the lower version in go.mod, so it's a little bit more backwards-compatible.

@pierluca
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants