Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xplique v0.4.2 #118

Merged
merged 12 commits into from
Nov 7, 2022
Merged

Xplique v0.4.2 #118

merged 12 commits into from
Nov 7, 2022

Conversation

fel-thomas
Copy link
Member

Rebase develop into master.

This PR includes:

#114 fix a missing module in the init of plot.
#115 which enhance documentation and smoothgrad batching mechanism.
#117 which fix a bug in the plot module and another one concerning the miniature of the feature viz.

I will push the v0.4.2 on pypi this afternoon.
Congrats everyone (@TeodorChiaburu, @AntoninPoche, @lucashervier) 🎉

Copy link
Collaborator

@lucashervier lucashervier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! There is some minor typo (or english) mistakes that is why I request change (otherwise it would be forgotten) but it is great work!

docs/api/attributions/deconvnet.md Outdated Show resolved Hide resolved
docs/api/attributions/grad_cam.md Outdated Show resolved Hide resolved
docs/api/attributions/grad_cam_pp.md Outdated Show resolved Hide resolved
docs/api/attributions/guided_backpropagation.md Outdated Show resolved Hide resolved
xplique/attributions/square_grad.py Show resolved Hide resolved
@fel-thomas
Copy link
Member Author

Done, thx @lucashervier ;) !
I kept the old description as suggested but fixed the typo.

Copy link
Collaborator

@lucashervier lucashervier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thx for the changes!

@fel-thomas fel-thomas merged commit 7891398 into master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants