Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup plot & Bump version #117

Merged
merged 3 commits into from Nov 2, 2022
Merged

Fixup plot & Bump version #117

merged 3 commits into from Nov 2, 2022

Conversation

fel-thomas
Copy link
Member

Plot Fixup and update to 0.4.2

The first commit fdea9f8 deal with the miniature of feature viz (compression and fix link in the doc).
The second commit 5c60d51 is quite urgent and fix a bug user are facing when running the getting started notebook (@AntoninPoche). See #116 (big thank to @semihcanturk, @9527-ly ^^ ).

I will open a new PR to rebase develop on master and deliver a new pypi version in the afternoon.

PS: in the long run, we might need an elegant way to integrate notebooks in the tests. I will think about it.

Copy link
Collaborator

@lucashervier lucashervier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thank you very much

@fel-thomas fel-thomas merged commit f9daa6a into develop Nov 2, 2022
@fel-thomas fel-thomas deleted the fel/fixup-plot branch November 2, 2022 12:53
@fel-thomas fel-thomas mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants