-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow option for invalid certificates for RTSPS #82
Comments
I think this is managed by vdk library and we'd need to plumb through a server option into the parameters of the webrtc client along with the url. |
This is exactly the problem I was facing with my unifi stuff. I can help with betatesting at most tho, I know next to nothing about video streaming. |
RTSPS - used certificate you cert created for 127.0.0.1 you connect you device using example 192.168.100 go to device settings and create cert you real host name |
I believe it is possible to replace the certificate on UniFi but the system does not make it easy (no UI option etc). Note that the default 127.0.0.1 certificate is pre installed by the OS and is likely re-instated upon updates. I will have a a play with this when I get a chance but it would be good I still thing to ignore this locally |
maybe there are tls options there but i need to look into this or you can do it yourself. |
I propose we set the flag |
try Line 27 in efeaa18
|
Nice, thanks for adding this. I think we need to "wire up" to test this in the home assistant add-on, unless one of you has a standalone instance of the server to try this out with. |
Add API call to support passing extra data in the stream channel. Issue https://github.com/allenporter/stream-addons/issues/32 Issue deepch/RTSPtoWeb#82
Add API call to support passing extra data in the stream channel. Issue https://github.com/allenporter/stream-addons/issues/32 Issue deepch/RTSPtoWeb#82
Add API call to support passing extra data in the stream channel. Issue https://github.com/allenporter/stream-addons/issues/32 Issue deepch/RTSPtoWeb#82
I was looking at adding support to the home assistant add-on and i think it would turn out to be simpler if we could set this at the top level config.json, for all streams, rather than per stream. Would that be alright with you? |
It would be great! But I'm still sick, it's very hard for me to work. |
Thanks I'll have a look |
fix worked for our needs as well. thank you! agree it should be global. thanks! |
Does it work with MSE or HLS? You could be seeing a webrtc port issue. |
@t3therdev thanks for replying, actually nothing works... |
share you stream need test it. |
@deepch tried again with modified url (rtsps => rtsp and the port), everything works. probably something is different with my previous unifi protects rtsps stream. |
For rtsps (let's keep rtsp out of scope) if anyone is trying with the new flag it would be helpful to confirm with log messages. Are they the same as the original bug filed or different? |
Yes, that's a good idea. |
As promised on #107, here is what I get via the debug log when trying to access my UniFi Protect Integration cameras via the integration:
This is what the picture looks like: I circumvented the certificate issue by setting:
Please let me know if any of this is useful! Thanks again for your work! |
Thanks for the detail, it sounds like this worked to resolve the certificate issue, but the unifi protect cameras still don't work over the RTSPS url, but the RTSP urls do work from what I hear. |
Can confirm! When I manually add the camera to config.json as described in #107, the cam works great. Sadly the integration only goes with RTSPS since that's the way forward for UniFi, so there may be some additional work required to make this function correctly. |
Update: now that #107 has been sorted, I can confirm that the cameras are added correctly to the configuration. As @azbutz pointed out, the issue seems to be isolated to the following query parameter that is added to the URL: |
You can still get the RTSP stream by Link |
UniFi protect serves RTSPS streams for cameras from the controller with a certificate valid for IPv4/6 loopbacks. Trying to connect to these feeds fails with log errors similar to:
It would be nice to allow the option to ignore the invalid certificate, in a trusted environment. For a little more context, see the discussions here.
The text was updated successfully, but these errors were encountered: