Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for filterting check results by name #2695

Merged
merged 5 commits into from Nov 7, 2023
Merged

Added support for filterting check results by name #2695

merged 5 commits into from Nov 7, 2023

Conversation

harsh-deepchecks
Copy link
Contributor

  • Added implementation for fetching the check results by header name of the check. I have added this functionality in the same function and added checks in order to accept either indexes or names (one of them required always).
  • Will be working on the other part of the task to figure out a way to know the row in the DF which causes any checks to fail so that user can know which data point is problematic.

@harsh-deepchecks harsh-deepchecks requested a review from a team as a code owner November 5, 2023 17:09
@harsh-deepchecks harsh-deepchecks self-assigned this Nov 5, 2023
@harsh-deepchecks harsh-deepchecks added bug feature Feature update or code change to the package labels Nov 5, 2023
Nadav-Barak
Nadav-Barak reviewed Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@Nadav-Barak Nadav-Barak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 2-3 tests for that functionality with different combinations between names and indexes

deepchecks/core/suite.py Outdated Show resolved Hide resolved
@harsh-deepchecks harsh-deepchecks requested a review from a team as a code owner November 7, 2023 10:57
@harsh-deepchecks harsh-deepchecks enabled auto-merge (squash) November 7, 2023 13:03
@harsh-deepchecks harsh-deepchecks merged commit cf4a7ea into main Nov 7, 2023
21 of 22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the harsh/dee-817-retrieve-check-result-by-name-from-suite-results-bug branch November 7, 2023 13:45
harsh-deepchecks added a commit that referenced this pull request Nov 22, 2023
@harsh-deepchecks
Added support for filterting check results by name (#2695) (#2701)
e99166f 
* Added support for filterting check results by name

* Minor fix

* Added unit tests

* Added doc string

* Some final changes
harsh-deepchecks added a commit that referenced this pull request Nov 22, 2023
@harsh-deepchecks
Added support for filterting check results by name (#2695) (#2702)
2948b74 
* Added support for filterting check results by name

* Minor fix

* Added unit tests

* Added doc string

* Some final changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadav-Barak Nadav-Barak Nadav-Barak approved these changes

@noamzbr noamzbr Awaiting requested review from noamzbr

Assignees

@harsh-deepchecks harsh-deepchecks

Labels
bug feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harsh-deepchecks @Nadav-Barak