Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for filterting check results by name #2695

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Added support for filterting check results by name #2695

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c793304
Added support for filterting check results by name
harsh-deepchecks Nov 5, 2023
c28fd15
Minor fix
harsh-deepchecks Nov 5, 2023
8310aac
Added unit tests
harsh-deepchecks Nov 6, 2023
535dfad
Added doc string
harsh-deepchecks Nov 6, 2023
96a6de3
Some final changes
harsh-deepchecks Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions deepchecks/core/suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,20 @@ def __init__(
else:
raise TypeError(f'Unknown type of result - {type(result).__name__}')

def select_results(self, idx: Set[int]) -> List[Union[
def select_results(self, idx: Set[int] = None, names: Set[str] = None) -> List[Union[
'check_types.CheckResult',
'check_types.CheckFailure'
]]:
"""Select results by indexes."""
"""Select results either by indexes or result header names."""
harsh-deepchecks marked this conversation as resolved.
Show resolved Hide resolved
if idx is None and names is None:
raise DeepchecksNotSupportedError('Either idx or names should be passed')
if idx and names:
raise DeepchecksNotSupportedError('Only one of idx or names should be passed')
output = []
for index, result in enumerate(self.results):
if index in idx:
if idx and index in idx:
output.append(result)
elif names and (result.get_header() in names or result.get_metadata()['name'] in names):
output.append(result)
return output

Expand Down