-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor featurizer #2017
Refactor featurizer #2017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some nice cleanup @nd-02110114! Swapping over to logging
instead of the old log
in the remaining spots and renaming featurize_complexes
to featurize
both are very nice.
I'm not sure whether we should delete MolecularWeightFeaturizer
or deprecate it first. It's not a publicly exposed class so it might be fine to delete it.
@@ -6,36 +6,6 @@ | |||
from deepchem.feat.base_classes import MolecularFeaturizer | |||
|
|||
|
|||
class MolecularWeight(MolecularFeaturizer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is safe to delete since it wasn't exposed in the public API deepchem/feat/__init__.py
. MolecularWeight
isn't an useful featurizer, and I don't think anyone was actually using it.
@peastman Do you think we're OK to delete this or would it be better to deprecate it instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we really think it's not useful, I'd be fine with just removing it.
CI failure is related to |
The only travis failures look to be mypy related so going to ahead and merge this in! |
What I did
MolecularWeight
andRDKitDescriptors
isbasic.py
, it is not so good... So, I removedMolecularWeight
and, renamed the file.featurize
methoddeepchem.utils.save.log