Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements concordance_index for regression evaluation #2263

Merged
merged 9 commits into from
Nov 3, 2020

Conversation

hsjang001205
Copy link
Contributor

@hsjang001205 hsjang001205 commented Oct 31, 2020

Similar to AUC in regression. Evaluate values for distributed differences, not accuracy.
As an example, if the IC50 value for drug A and B is each 30 and 40, the predicted value for A should be lower than B.
It is a value of whether there is a significant distributional difference with the ranking information.
(often used in clinical data.)

(Lifelines provides more extended functions, so it would be a good idea to consider that.)

Copy link
Member

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!
I just commented the docstring for the return value.

deepchem/metrics/score_function.py Outdated Show resolved Hide resolved
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsjang001205 Looks good! Almost ready to merge in. Have one minor request about adding this to the docs and we should be good to merge in

deepchem/metrics/score_function.py Show resolved Hide resolved
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge when ready :)

@nissy-dev
Copy link
Member

I merge in. This is because this PR touch docs, so the conflict will happen if my #2257 merge ahead.

@nissy-dev nissy-dev merged commit d79c5ea into deepchem:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants