Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Log Transform for Clearance and HPPB #2462

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Use Log Transform for Clearance and HPPB #2462

merged 5 commits into from
Apr 6, 2021

Conversation

mufeili
Copy link
Contributor

@mufeili mufeili commented Apr 1, 2021

Pull Request Template

@rbharath

Description

As previously discussed in the two issues below:

This PR applies log-transform to the labels by default.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.22.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rbharath
Copy link
Member

rbharath commented Apr 6, 2021

It looks like the only failing test is the known error with mol2vec fingerprint. Going to go ahead and merge this in!

@rbharath rbharath merged commit 3b89282 into deepchem:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants