-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sparse/Lazy Adam optimizer #2493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
=======================================
Coverage 85.77% 85.78%
=======================================
Files 309 309
Lines 27454 27488 +34
=======================================
+ Hits 23550 23580 +30
- Misses 3904 3908 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good on my end! Might be good to have @peastman take a quick look as well since he's been reviewing the other optimizer PRs
Ah my bad, sorry just noticed this is a WIP. Let me know when this is ready to review! |
@rbharath It should be ready to review 😅 I marked it as a draft due to the additional dependency temporarily. I'll go ahead and mark it open for review now. |
Looks good! |
Except yapf is complaining. Can you run it on test_optimizers.py? |
Sorry about that, I've committed the YAPF reformatting. @peastman |
Going to go ahead and merge in! |
Description
Added the Sparse Adam optimizer, also known as the Lazy Adam optimizer.
Referencing #2478
This change requires the
Tensorflow Addons
dependency, which is an official extension of the Tensorflow library. This PR is intended to be merged after #2488Type of change
Please check the option that is related to your PR.
All tests for
test_optimizers.py
are passing.The warnings seem to be unrelated to the added code.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.22.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errors@rbharath @alat-rights @peastman @ncfrey
P.S. I have made this PR a draft PR at the moment. If the addition of TF_Addons is alright, I will change it to an Open PR.