-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed return type to np.ndarray in a few files #2607
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2607 +/- ##
==========================================
- Coverage 53.84% 53.84% -0.01%
==========================================
Files 320 320
Lines 28510 28510
==========================================
- Hits 15352 15351 -1
- Misses 13158 13159 +1
Continue to review full report at Codecov.
|
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry might have missed this discussion. Are we seeing errors in mypy elsewhere that mean we need this fix?
I am not sure about the errors, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that makes sense! Ok marking this one ready to merge in
There are some formatting issues here. |
I've run yapf on the file again. The change seems unrelated to the change but hopefully it'll pass the CI now. |
It's passing now but on GitHub Actions, yapf is only run on the files that were changed
|
Test failures look unrelated to so going to go ahead and merge in |
Pull Request Template
Description
Fix #(issue)
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.22.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errors