Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed return type to np.ndarray in a few files #2607

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Changed return type to np.ndarray in a few files #2607

merged 3 commits into from
Jul 22, 2021

Conversation

atreyamaj
Copy link
Contributor

Pull Request Template

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.22.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@atreyamaj atreyamaj changed the title Changed return type to np.ndarray in docking_utils.py::read_gnina_log Changed return type to np.ndarray in a few files Jul 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #2607 (1b6a4fe) into master (86042a0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
- Coverage   53.84%   53.84%   -0.01%     
==========================================
  Files         320      320              
  Lines       28510    28510              
==========================================
- Hits        15352    15351       -1     
- Misses      13158    13159       +1     
Impacted Files Coverage Δ
deepchem/data/data_loader.py 88.31% <100.00%> (ø)
deepchem/utils/docking_utils.py 81.18% <100.00%> (ø)
deepchem/rl/envs/tictactoe.py 81.39% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86042a0...1b6a4fe. Read the comment docs.

@vsomnath
Copy link
Contributor

Looks good to me!

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry might have missed this discussion. Are we seeing errors in mypy elsewhere that mean we need this fix?

@vsomnath
Copy link
Contributor

I am not sure about the errors, but np.array is a function and np.ndarray is the actual type of the numpy array.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense! Ok marking this one ready to merge in

@vsomnath
Copy link
Contributor

There are some formatting issues here.

@atreyamaj
Copy link
Contributor Author

atreyamaj commented Jul 22, 2021

There are some formatting issues here.

I've run yapf on the file again. The change seems unrelated to the change but hopefully it'll pass the CI now.

@vsomnath
Copy link
Contributor

It's passing now but on GitHub Actions, yapf is only run on the files that were changed

Run CHANGED_FILES=`git diff --name-only $COMMIT_RANGE | grep .py$ | grep -v contrib/ || true`

@rbharath
Copy link
Member

Test failures look unrelated to so going to go ahead and merge in

@rbharath rbharath merged commit 906613b into deepchem:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants