type fixes for pep 484 compliance #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some type fixes for compliance with pep 484.
PEP 484 prohibits the use of implicit optional. For example, the following piece of code allows assumption of implicit optional:
def foo(a: int = None): .... It allows type checkers to assume an optional type ofNonefora. To comply with PEP 484, it should bedef foo(a: Optional[int] = None): ....The latest mypy version (0.991, release blog) had a breaking change which disabled implicit optionals type. Hence, it was not detected earlier by mypy.