New Code formatting CI #3278
Merged
New Code formatting CI #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbharath
reviewed
Mar 15, 2023
.github/workflows/new_formatting.yml
Outdated
| channels: conda-forge,defaults | ||
| extra-specs: python=${{ matrix.python-version }} | ||
|
|
||
| # - name: Install all dependencies using conda |
There was a problem hiding this comment.
Do we want this commented out portion?
There was a problem hiding this comment.
removed it as it is not needed.
Yes
A single code formatting run takes ~10 mins. Earlier, we had 3 runs on a pull request, 3 runs on a push ~ 60 mins. Now, a single run on pull request, a single run on push. ~20 mins. We save about 40 mins.
Not any since the checks are platform independent. |
rbharath
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A breakdown of #3246 into smaller pull request.
I moved code formatting checks - yapf, flake8, mypy to run in a new workflow under single OS (ubuntu) and single python version (3.9). The new workflow checks only for formatting.