-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Code formatting CI #3278
New Code formatting CI #3278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, the only change in this PR is that the install/formatting checks now only run on ubuntu/3.9? How many minutes do we expect this to save us on the run?
Is there any edge case where running on mac could catch something this new test wouldn't?
.github/workflows/new_formatting.yml
Outdated
channels: conda-forge,defaults | ||
extra-specs: python=${{ matrix.python-version }} | ||
|
||
# - name: Install all dependencies using conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this commented out portion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it as it is not needed.
Yes
A single code formatting run takes ~10 mins. Earlier, we had 3 runs on a pull request, 3 runs on a push ~ 60 mins. Now, a single run on pull request, a single run on push. ~20 mins. We save about 40 mins.
Not any since the checks are platform independent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge in once CI is clear
Description
A breakdown of #3246 into smaller pull request.
I moved code formatting checks - yapf, flake8, mypy to run in a new workflow under single OS (ubuntu) and single python version (3.9). The new workflow checks only for formatting.