Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding grover finetune model #3335

Merged
merged 4 commits into from
Apr 5, 2023
Merged

adding grover finetune model #3335

merged 4 commits into from
Apr 5, 2023

Conversation

arunppsg
Copy link
Contributor

@arunppsg arunppsg commented Apr 4, 2023

Description

Adding GroverFinetune module which will be later initialized by GroverModularTorchModel for pretraining GroverModel. This is a breakdown of #3272 into smaller one.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@arunppsg arunppsg marked this pull request as draft April 4, 2023 03:21
@arunppsg arunppsg marked this pull request as ready for review April 4, 2023 05:02
rbharath
rbharath approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@rbharath rbharath left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to go. One minor request below to add to the docs.

LGTM in the interest of speed. Feel free to merge after adding the new layer to the docs and once the CI looks good

deepchem/models/torch_models/grover.py
from typing import List
from deepchem.models.torch_models.grover_layers import GroverTransEncoder


class GroverFinetune(nn.Module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this class to layers.rst?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to docs, I also added the test which I forgot to commit in 4633b41

@arunppsg arunppsg merged commit e41239d into deepchem:master Apr 5, 2023
@arunppsg arunppsg mentioned this pull request Apr 6, 2023
Merged
15 tasks
@arunppsg arunppsg deleted the grover-finetune branch April 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbharath rbharath rbharath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arunppsg @rbharath