-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descriptive names for ci runs #3336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple unrelated changes in this PR. I'd suggest splitting up into a few smaller PRs (pull request template simplification, descriptive names, cache changes). I'm not sure about the cache change in particular, so let's discuss that offline
.github/workflows/jax_setup.yml
Outdated
uses: actions/cache@v3 | ||
with: | ||
path: ~/.cache/pip | ||
key: ${{ runner.os }}-pip-${{ hashFiles('requirements/jax/**') }} | ||
restore-keys: | | ||
${{ runner.os }}-pip- | ||
- name: Cache pip packages for MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pytest runs on mac right? Let's chat offline
1ca9ca6
to
a2adecb
Compare
I have made cache changes into a separate pull request (#3342 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unrelated to this PR, it looks like there is a Grover failure:
_________________________ testGroverBondVocabPredictor _________________________
@pytest.mark.torch
def testGroverBondVocabPredictor():
from deepchem.models.torch_models.grover_layers import GroverBondVocabPredictor
num_bonds = 20
in_features, vocab_size = 16, 10
layer = GroverBondVocabPredictor(vocab_size, in_features)
embedding = torch.randn(num_bonds * 2, in_features)
> result = layer(embedding)
deepchem/models/torch_models/tests/test_grover_layers.py:49:
Can you take a look and address in a follow up PR @gusty1g ?
The failure in grover was addressed in #3335. Since this branch is not updated with master branch, it is popping up here. |
a missed update to ci name
Description
Summary of changes:
if
conditions) since our CI does not run in macOS. Only the build CI runs in macOS and macOS installation is preserved there.Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors