-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFT XC Model #3363
DFT XC Model #3363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close! Mostly documentation issues below
@@ -248,3 +248,6 @@ Density Functional Theory Layers | |||
|
|||
.. autoclass:: deepchem.models.dft.scf.XCNNSCF | |||
:members: | |||
|
|||
.. autoclass:: deepchem.models.dft.dftxc.DFTXC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the DFT layers to the new table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting offline discussion, to be done in a follow up PR, with DFT layers to be added to https://github.com/deepchem/deepchem/blob/master/docs/source/api_reference/torch_layers.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are strange errors on the CI from pip failing to install in the conda environment.
Description
Fix #(issue)
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors