Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context pred GNN Modular #3369

Merged
merged 32 commits into from
May 1, 2023
Merged

Conversation

tonydavis629
Copy link
Collaborator

Description

Implements the context prediction task for GNNModular from Strategies for Pretraining Graph Neural Networks by Hu et al 2020.

Context prediction is the task of predicting the surrounding nodes and edges of a chosen root node. Empirical results show better performance over masking nodes or edges.

Type of change

Please check the option that is related to your PR.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
  • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
  • Run mypy -p deepchem and check no errors
  • Run flake8 <modified file> --count and check no errors
  • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's break out the graphdata changes into their own smaller PR for simplicity

deepchem/models/tests/test_losses.py Outdated Show resolved Hide resolved
deepchem/models/losses.py Show resolved Hide resolved
deepchem/models/losses.py Outdated Show resolved Hide resolved
deepchem/feat/graph_data.py Outdated Show resolved Hide resolved
deepchem/feat/graph_data.py Outdated Show resolved Hide resolved
deepchem/feat/graph_data.py Outdated Show resolved Hide resolved
deepchem/models/torch_models/gnn.py Show resolved Hide resolved
deepchem/models/torch_models/gnn.py Outdated Show resolved Hide resolved
deepchem/models/torch_models/gnn.py Show resolved Hide resolved
deepchem/models/torch_models/gnn.py Outdated Show resolved Hide resolved
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 9784382 into deepchem:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants