Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the deprecated usage of torch.Tensor.grad.data #3726

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

HridayM25
Copy link
Contributor

@HridayM25 HridayM25 commented Dec 15, 2023

Description

Fix #3217

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaipranesh2 Can you review this PR?

Copy link
Contributor

@shaipranesh2 shaipranesh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HridayM25 The code formatting test are failing due to change in yapf version

@HridayM25
Copy link
Contributor Author

@shaipranesh2 Thanks for the review! I am using yapf whose version is 0.32.0. How should I proceed?

@shaipranesh2
Copy link
Contributor

@HridayM25 Rest seems fine as detach() here does not alter the computation graph of the KFAC. Should be ready to merge once code formatting tests pass

@HridayM25
Copy link
Contributor Author

@shaipranesh2 Right, the computation graph is not affected with detach. What should I do to ensure the code formatting tests pass?

@shaipranesh2
Copy link
Contributor

@shaipranesh2 Thanks for the review! I am using yapf whose version is 0.32.0. How should I proceed?

I am not sure then. The CI tests expected a different formatting than the one in this PR. So check the logs and rerun the yapf command maybe.

@HridayM25
Copy link
Contributor Author

HridayM25 commented Dec 18, 2023

@shaipranesh2 I checked the logs, and I have made the necessary changes. I also ran yapf afterwards and it gave me no errors.

@HridayM25
Copy link
Contributor Author

@rbharath @shaipranesh2 The formatting issue seems to be solved now.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 819c134 into deepchem:master Dec 27, 2023
48 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch.Tensor.grad.data attribute is deprecated - update it's usage
3 participants