-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the deprecated usage of torch.Tensor.grad.data #3726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shaipranesh2 Can you review this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HridayM25 The code formatting test are failing due to change in yapf version
@shaipranesh2 Thanks for the review! I am using yapf whose version is 0.32.0. How should I proceed? |
@HridayM25 Rest seems fine as detach() here does not alter the computation graph of the KFAC. Should be ready to merge once code formatting tests pass |
@shaipranesh2 Right, the computation graph is not affected with detach. What should I do to ensure the code formatting tests pass? |
I am not sure then. The CI tests expected a different formatting than the one in this PR. So check the logs and rerun the yapf command maybe. |
@shaipranesh2 I checked the logs, and I have made the necessary changes. I also ran yapf afterwards and it gave me no errors. |
@rbharath @shaipranesh2 The formatting issue seems to be solved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix #3217
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors