-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed Trainer #3745
Distributed Trainer #3745
Conversation
@@ -26,7 +26,7 @@ class DCLightningDatasetModule(pl.LightningDataModule): | |||
This class requires PyTorch to be installed. | |||
""" | |||
|
|||
def __init__(self, dataset, batch_size, collate_fn): | |||
def __init__(self, dataset, batch_size, collate_fn, num_workers: int): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs reminder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add type annotations while we're at it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added type annotations and docs
2fb9af9
to
ab05099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, let's not make trainer a top level module but let's add dc.models.trainer
as a submodule. Once those changes are made and tests are fixed, we should be good to merge in
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there's a bug that needs to be fixed before merge on the CI for the distributed trainer.
Fixed CI error and merging this in. |
DistributedTrainer for DeepChem.