Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to PyTorch Lightning #3766

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

arunppsg
Copy link
Contributor

@arunppsg arunppsg commented Jan 4, 2024

Description

This PR updated PyTorch Lightning to work with ModularTorchModel and it has to be merged in before #3745 .

A couple of other changes have also been made:

  • added num workers arg to load dataset using multiple workers
  • update pytorch-lightning to Lightning in imports as they are transitioning their namespace to Lightning (ref, example)
  • Added documentation to DCLightningDataModule

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@@ -55,24 +57,25 @@ def training_step(self, batch, batch_idx):
assert len(inputs) == 1
inputs = inputs[0]

outputs = self.pt_model(inputs)
if isinstance(self.dc_model, ModularTorchModel):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests for ModularTorchModel + lightning in a follow up PR

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit eaad47c into deepchem:master Jan 6, 2024
24 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants