Added eslint, jshint config. Fixes #99

WIP #99 Updated code style violations

.eslintignore

@@ -0,0 +1,4 @@
+src/common/lua.js
+src/visualizers/widgets/TextEditor/lib/*
+src/common/js-yaml.min.js
+src/visualizers/Visualizers.json

.eslintrc.yml

@@ -0,0 +1,18 @@
+env:
+  browser: true
+  mocha: true
+  es6: true
+extends: 'eslint:recommended'
+rules:
+  indent:
+    - error
+    - 4
+  linebreak-style:
+    - error
+    - unix
+  quotes:
+    - error
+    - single
+  semi:
+    - error
+    - always

.jshintrc

@@ -0,0 +1,3 @@
+{
+    "esversion": 6
+}

src/common/GraphChecker.js

@@ -1,3 +1,4 @@
+/* globals define */
 define([
     'deepforge/js-yaml.min'
 ], function(
@@ -148,28 +149,11 @@ define([
 
     GraphChecker.prototype = new Importer();
 
-    // Check if two models are isomorphic
-    var modelMatches = function(gmeNodes, text) {
-        var nodes = convertNodes(gmeNodes),
-            soln = yaml.load(text);
-
-        nodes.concat(soln).forEach(node => {
-            node.next = node.next || [];
-            node.attributes = node.attributes || {};
-        });
-
-        return _modelMatches(nodes, soln);
-    };
-
     //////////////// Operators ////////////////
+    // Check if two models are isomorphic
     var _modelMatches = function(soln, nodes) {
         var nodeMap = createMap(nodes),
-            solnMap = createMap(soln),
-            sInits,  // soln start nodes
-            nInits,  // 'nodes' start nodes
-            resMap = {},  // soln node id to node id
-            solnIds = soln.map(n => n.id),
-            nodeIds = nodes.map(n => n.id);
+            solnMap = createMap(soln);
 
         if (nodes.length !== soln.length) {
             return false;
@@ -187,8 +171,7 @@ define([
     };
 
     var getMostConstrained = function(soln, nodes) {
-        var options = soln.map(sn => [sn, nodes.filter(n => nodesMatch(sn, n))]),
-            startId;
+        var options = soln.map(sn => [sn, nodes.filter(n => nodesMatch(sn, n))]);
 
         options.sort((a, b) => b[1].length < a[1].length);
         return options[0];
@@ -199,8 +182,7 @@ define([
             nodes = Object.keys(nodeMap).map(id => nodeMap[id]),
             snode = solnMap[id],
             options,
-            used,
-            node;
+            used;
 
         mappings = mappings || {};
 
@@ -247,14 +229,16 @@ define([
             snext.push(startId);
         }
 
+        var inferNext = (prev, curr) => {
+            mappings2 = inferGraph(curr, solnMap, nodeMap, mappings2);
+            return prev && mappings;
+        };
+
         for (var i = options.length; i--;) {
             mappings[id] = options[i].id;  // need to clone the object
 
             mappings2 = clone(mappings);
-            result = snext.reduce((prev, curr) => {
-                mappings2 = inferGraph(curr, solnMap, nodeMap, mappings2);
-                return prev && mappings;
-            }, true);
+            result = snext.reduce(inferNext, true);
 
             if (result) {
                 return mappings2;

src/common/layer-args.js

@@ -1,3 +1,4 @@
+/* globals define*/
 define([
 ], function(
 ) {
@@ -25,7 +26,6 @@ define([
     var createLayerDict = function(core, meta) {
         var node,
             names = Object.keys(meta),
-            attributes,
             layers = {};
 
         for (var i = names.length; i--;) {

src/decorators/OperationDecorator/EasyDAG/OperationDecorator.EasyDAGWidget.js

@@ -28,6 +28,7 @@ define([
 
     _.extend(OperationDecorator.prototype, DecoratorBase.prototype);
 
+    OperationDecorator.prototype.DECORATOR_ID = DECORATOR_ID;
     OperationDecorator.prototype.expand = function() {
         DecoratorBase.prototype.expand.call(this);
         // Add the ports for data inputs/outputs
@@ -36,7 +37,7 @@ define([
         //var outputs = this._node.outputs;
     };
 
-    OperationDecorator.prototype._highlightPort = function(name) {
+    OperationDecorator.prototype._highlightPort = function(/*name*/) {
         // Highlight port with the given name
         // TODO
     };

src/plugins/CreateExecution/CreateExecution.js

@@ -60,7 +60,7 @@ define([
         }
 
         return this.createExecution(this.activeNode)
-            .then(node => {
+            .then(() => {
                 this.result.setSuccess(true);
                 callback(null, this.result);
             })
@@ -103,7 +103,7 @@ define([
                 );
             })
             .then(() => {  // datamapping is set!
-                this.updateReferences(copies, dataMapping)
+                this.updateReferences(copies, dataMapping);
                 this.boxOperations(opTuples.map(o => o[0]), tgtNode);
                 return this.save(`Created execution of ${name}`);
             })
@@ -152,8 +152,7 @@ define([
     CreateExecution.prototype.sortIOByName = function (container) {
         return container.sort((a, b) =>
             // sort by name
-            this.core.getAttribute(a, 'name') < this.core.getAttribute(b, 'name')
-                ? 1 : -1
+            this.core.getAttribute(a, 'name') < this.core.getAttribute(b, 'name') ? 1 : -1
         );
     };
 

src/plugins/CreateTorchMeta/CreateTorchMeta.js

@@ -51,8 +51,7 @@ define([
     CreateTorchMeta.prototype.main = function (callback) {
         // Use self to access core, project, result, logger etc from PluginBase.
         // These are all instantiated at this point.
-        var self = this,
-            nodeObject;
+        var self = this;
 
         if (!this.META.Language) {
             callback('"Language" container required to run plugin', this.result);

src/plugins/ExecutePipeline/Templates.js

@@ -1,3 +1,4 @@
+/*globals define*/
 define([
     'text!./entry.ejs',
     'text!./main.ejs',

src/plugins/GenerateArchitecture/GenerateArchitecture.js

@@ -65,7 +65,7 @@ define([
         for (var i = 0; i < layers.length; i++) {
             if (layers[i][Constants.NEXT].length > 1) {
                 // no support for 
-                console.error('No support for parallel layers... yet');
+                this.logger.error('No support for parallel layers... yet');
                 break;
             } else {
                 // args

src/plugins/GenerateArchitecture/dimensionality.js

@@ -1,3 +1,4 @@
+/* globals define */
 define([
     'SimpleNodes/Constants',
     'deepforge/lua'

src/plugins/ImportTorch/nn.js

@@ -1,3 +1,4 @@
+/* globals define */
 // This is the searcher for the mock library
 define([
     'deepforge/layer-args',
@@ -10,10 +11,10 @@ define([
 ) {
     'use strict';
 
-    var nop = function() {};
     var createSearcher = function(plugin) {
         var core = plugin.core,
             META = plugin.META,
+            logger = plugin.logger.fork('nn'),
             parent = plugin.tgtNode,
             LayerDict = createLayerDict(core, META);
 
@@ -41,8 +42,7 @@ define([
         };
 
         Layer.prototype._node = function() {
-            var attrs = this._attrs,
-                name,
+            var name,
                 node,
                 value;
 
@@ -83,20 +83,19 @@ define([
             this._outputs = [];
         };
 
-        Container.prototype.add = function(self, tlayer) {
-            console.error('Add is not overridden!');
+        Container.prototype.add = function() {
+            logger.error('Add is not overridden!');
         };
 
-        var Sequential = function(attrs, args) {
+        var Sequential = function(/*attrs, args*/) {
             Container.call(this);
         };
 
         Sequential.prototype = new Container();
 
         Sequential.prototype.add = function(self, tlayer) {
             var layer = tlayer.get('_node'),
-                nodes = layer._inputs,
-                conn;
+                nodes = layer._inputs;
 
             // If this._inputs is empty, add the layer to the inputs list
             if (this._inputs.length === 0) {  // first node
@@ -146,15 +145,12 @@ define([
         var CreateLayer = function(type) {
             var res = luajs.newContext()._G,
                 attrs = [].slice.call(arguments, 1),
-                proto,
                 node;
 
             if (LAYERS[type]) {
                 node = new LAYERS[type](LayerDict[type] || [], attrs);
-                proto = LAYERS[type].prototype;
             } else {  // Call generic Layer with type name
                 node = new Layer(type, LayerDict[type] || [], attrs);
-                proto = Layer.prototype;
             }
 
             res.set('_node', node);

src/visualizers/Visualizers.json

@@ -1,44 +1,44 @@
 [
-  {
-    "id": "AutoViz",
-    "title": "AutoViz",
-    "panel": "panels/AutoViz/AutoVizPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "EasyDAG",
-    "title": "EasyDAG",
-    "panel": "panels/EasyDAG/EasyDAGPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "ArchEditor",
-    "title": "ArchEditor",
-    "panel": "panels/ArchEditor/ArchEditorPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "TextEditor",
-    "title": "TextEditor",
-    "panel": "panels/TextEditor/TextEditorPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "OperationEditor",
-    "title": "OperationEditor",
-    "panel": "panels/OperationEditor/OperationEditorPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "PipelineEditor",
-    "title": "PipelineEditor",
-    "panel": "panels/PipelineEditor/PipelineEditorPanel",
-    "DEBUG_ONLY": false
-  },
-  {
-    "id": "ExecutionView",
-    "title": "ExecutionView",
-    "panel": "panels/ExecutionView/ExecutionViewPanel",
-    "DEBUG_ONLY": false
-  }
-]
+    {
+        "id": "AutoViz",
+        "title": "AutoViz",
+        "panel": "panels/AutoViz/AutoVizPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "EasyDAG",
+        "title": "EasyDAG",
+        "panel": "panels/EasyDAG/EasyDAGPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "ArchEditor",
+        "title": "ArchEditor",
+        "panel": "panels/ArchEditor/ArchEditorPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "TextEditor",
+        "title": "TextEditor",
+        "panel": "panels/TextEditor/TextEditorPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "OperationEditor",
+        "title": "OperationEditor",
+        "panel": "panels/OperationEditor/OperationEditorPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "PipelineEditor",
+        "title": "PipelineEditor",
+        "panel": "panels/PipelineEditor/PipelineEditorPanel",
+        "DEBUG_ONLY": false
+    },
+    {
+        "id": "ExecutionView",
+        "title": "ExecutionView",
+        "panel": "panels/ExecutionView/ExecutionViewPanel",
+        "DEBUG_ONLY": false
+    }
+]