Major aggregation factory and completeness cleanup #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
force-pushed
the
rwc-aggcleanup-1
branch
from
9167096
to
2cabfb3
Compare
… esoteric aggs not in the API yet.
rcaudy
force-pushed
the
rwc-aggcleanup-1
branch
from
2cabfb3
to
6adf0c7
Compare
cpwright
reviewed
Feb 1, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationContext.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/TotalsTableBuilder.java
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/TestAggBy.java
Show resolved
Hide resolved
java-client/session/src/main/java/io/deephaven/client/impl/BatchTableRequestBuilder.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationProcessor.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationProcessor.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationProcessor.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationProcessor.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/AggregationProcessor.java
Outdated
Show resolved
Hide resolved
… missing AggFreeze factory method.
…que in AggregationProcessor
cpwright
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
Fixes #1661
Adds: (These all existed previously, but were only accessible via obscure construction patterns in the
engine-tablemodule.)AggUniqueoptionsAggFirstRowKeyAggLastRowKeyAggTDigestAggApproximatePercentileAggFreezeImproves the mechanism for specifying multiple
AggPctpercentiles, and uses the same pattern forAggApproxPct.More importantly (but less exciting from a user-facing standpoint), eliminates duplicative code paths in aggregation translation (from user intent expressed via
Aggregationto actual chunked operators in anAggregationContext). This logic is now mostly self-contained within the newAggregationProcessorclass, with minimal glue inQueryTableand a handful of visitors.