Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AggSpecUnique is missing noValue and nonUniqueValue options #1661

Closed
rcaudy opened this issue Dec 8, 2021 · 6 comments · Fixed by #1903
Closed

AggSpecUnique is missing noValue and nonUniqueValue options #1661

rcaudy opened this issue Dec 8, 2021 · 6 comments · Fixed by #1903
Assignees
Labels
bug Something isn't working query engine table api
Milestone

Comments

@rcaudy
Copy link
Member

rcaudy commented Dec 8, 2021

Needs to match the feature set of io.deephaven.engine.table.impl.by.UniqueSpec.

@rcaudy rcaudy added bug Something isn't working query engine table api labels Dec 8, 2021
@rcaudy rcaudy added this to the Dec 2021 milestone Dec 8, 2021
@rcaudy rcaudy self-assigned this Dec 8, 2021
@devinrsmith
Copy link
Member

One interesting part about this problem is serialization - how is a remote client expected to be able to configure these values? It's an "easy" answer for primitives, strings, and nulls.

@rcaudy
Copy link
Member Author

rcaudy commented Dec 9, 2021

It's a problem, sure, but I'm willing to say the remote client just can't express this for some types (or any, for now).

@devinrsmith
Copy link
Member

It may make sense to create a Literal interface as a subset of io.deephaven.api.value.Value (ie, everything that isn't a ColumnName).

@rcaudy
Copy link
Member Author

rcaudy commented Dec 10, 2021

As a wrapper for an Object?

@rcaudy
Copy link
Member Author

rcaudy commented Dec 10, 2021

Keeping "onlyNullsValue" (AKA "noKeyValue") out of AggSpecUnique for now.

@rcaudy
Copy link
Member Author

rcaudy commented Dec 10, 2021

Adding "nonUniqueSentinel" as a nullable Object param.

@pete-petey pete-petey modified the milestones: Dec 2021, Jan 2022 Dec 29, 2021
mofojed pushed a commit that referenced this issue Dec 11, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0

# [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11)


### Bug Fixes

* add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6))
* adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e))
* convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650)
* Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355)
* Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966))
* popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204))
* Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677)


### Features

* Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629)
* forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529)
* Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410)
* theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef))
* Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660)
* Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0))
* Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e))
* View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605)


### BREAKING CHANGES

* Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes.
* Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working query engine table api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants