Adjust parameters for floating point tests #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
lbooker42
commented
Dec 29, 2023
...rc/main/java/io/deephaven/engine/table/impl/updateby/BucketedPartitionedUpdateByManager.java
Show resolved
Hide resolved
lbooker42
commented
Dec 29, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/ZeroKeyUpdateByManager.java
Show resolved
Hide resolved
lbooker42
changed the title
niloc132
approved these changes
Dec 31, 2023
rcaudy
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzed test sensitivity and changes made during the datagen updates (#4735) and verified the changes are correct and do not mask inaccuracies in the operations being tested.
Using floating point values with varying magnitudes increases floating point error, pushing it beyond the "acceptable" level of error in these tests. Adjusting the tests to produce random values clustered within the same magnitude reduces the final error and allows these tests to pass.
Closes #4743.