Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup component mappings and utils #425

Closed
bmingles opened this issue Apr 18, 2024 · 0 comments · Fixed by #424, #523 or #530
Closed

Cleanup component mappings and utils #425

bmingles opened this issue Apr 18, 2024 · 0 comments · Fixed by #424, #523 or #530
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
May 2024

Comments

@bmingles
Copy link
Contributor

bmingles commented Apr 18, 2024 •
edited
Loading

We currently map some components via SPECTRUM_ELEMENT_TYPE_PREFIX and others more directly. #512 will remove our last Spectrum dependencies, so we should clean things up and make the mappings more explicit / consistent.
@bmingles bmingles added enhancement New feature or request triage labels Apr 18, 2024
@bmingles bmingles mentioned this issue Apr 18, 2024
Merged
@vbabich vbabich added this to the April 2024 milestone Apr 23, 2024
@vbabich vbabich removed the triage label Apr 23, 2024
bmingles added a commit that referenced this issue Apr 24, 2024
@bmingles
refactor: Updated spectrum imports to use dh components (#424)
db97c9a 
Imports for Spectrum components that are available in
`@deephaven/components` have been updated.

Components that are not yet re-exported by @deephaven/components:
- `ButtonGroup`, `Checkbox` - we have our own implementations of these
#433

We also will want to rename some things such that DH components aren't
mapped to `SPECTRUM_ELEMENT_TYPE_PREFIX`
#425

#366
@bmingles bmingles linked a pull request Apr 29, 2024 that will close this issue
refactor: Updated spectrum imports to use dh components #424
Merged
@mofojed mofojed modified the milestones: April 2024, May 2024 May 28, 2024
@mofojed mofojed closed this as completed Jun 3, 2024
@mofojed mofojed reopened this Jun 3, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 3, 2024
@bmingles
Update DH packages to ^0.80.0 jsapi-types to ^1.0.0-dev0.34.3 (deepha…
87cecfc 
…ven#425)
@bmingles bmingles mentioned this issue Jun 3, 2024
Merged
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 3, 2024
@bmingles
Added nanoid to moduleNameMapper exclusion (deephaven#425)
54f349f
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 3, 2024
@bmingles
Remove spectrum dependency (deephaven#425)
d623bf3
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 4, 2024
@bmingles
Updated dh to ^0.80.1 (deephaven#425)
45a63e1
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 4, 2024
@bmingles
Remove spectrum dependency (deephaven#425)
09a1cda
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 4, 2024
@bmingles
Updated DH packages to ^0.81.1 (deephaven#425)
65f0b1d
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 4, 2024
@bmingles
Remove spectrum dependency (deephaven#425)
053dc98
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 5, 2024
@bmingles
Fixed jsapi-types version (deephaven#425)
e8ad604
bmingles added a commit that referenced this issue Jun 5, 2024
@bmingles
chore: Update DH packages to ^0.81.1 jsapi-types to ^1.0.0-dev0.34.3 (#…
59d2df4 
…511)

Update DH packages to ^0.81.1 jsapi-types to ^1.0.0-dev0.34.3

#425
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 5, 2024
@bmingles
Remove spectrum dependency (deephaven#425)
3bf4654
@bmingles bmingles changed the title Remap dh components that were formerly Spectrum components Cleanup component mappings and utils Jun 5, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 5, 2024
@bmingles
Moved spectrum ui components (deephaven#425)
6b8433a
@bmingles bmingles mentioned this issue Jun 6, 2024
Merged
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 6, 2024
@bmingles
Fixed mapping (deephaven#425)
dfd1328
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 6, 2024
@bmingles
Fixed duplicate Item mapping (deephaven#425)
241ba26
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 6, 2024
@bmingles
Removed unused import (deephaven#425)
bad1222
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 6, 2024
@bmingles
Handling uppercase orientation in RadioGroup (deephaven#425)
87aaf16
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 6, 2024
@bmingles
Implicit <Text> wrapping of primitives (deephaven#425)
d888c60
@bmingles bmingles mentioned this issue Jun 6, 2024
Merged
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 7, 2024
@bmingles
Making component imports explicit (deephaven#425)
67ed9c9
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 7, 2024
@bmingles
Exporting combo_box (deephaven#425)
701e566
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Addressing review comments (deephaven#425)
6af4822
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Renamed base_element (deephaven#425)
d4088a8
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Make orientation prop case insensitive (deephaven#425)
9233864
@bmingles bmingles mentioned this issue Jun 10, 2024
Merged
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Fixed types (deephaven#425)
95f0626
bmingles added a commit that referenced this issue Jun 10, 2024
@bmingles
feat: Make RadioGroup orientation prop case insensitive (#536)
9b0b498 
Most of our dh ui string enumerations are "CAPITALIZED". Make RadioGroup
`orientation` prop consistent.

```python
from deephaven import ui

@ui.component
def ui_radio_group():
    return ui.radio_group(
        ui.radio('One', value="one"),
        ui.radio('Two', value="two"),
        label="Radio Group",
        orientation="HORIZONTAL"
    )

my_radio_group = ui_radio_group()
```

#425
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Moved spectrum ui components (deephaven#425)
e74bdbb
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Fixed mapping (deephaven#425)
7bc73f7
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Fixed duplicate Item mapping (deephaven#425)
db39706
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Removed unused import (deephaven#425)
c9ed4c0
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Added quick and dirty e2e test to verify all ui components render (de…
aaac122 
…ephaven#425)
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Making component imports explicit (deephaven#425)
1a85564
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Exporting combo_box (deephaven#425)
ce5e985
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Addressing review comments (deephaven#425)
fedf540
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 10, 2024
@bmingles
Renamed base_element (deephaven#425)
a7ee2fe
bmingles added a commit that referenced this issue Jun 13, 2024
@bmingles
refactor: Cleanup component mappings and utils (python side) (#523)
195f334 
This is the first of 2 PRs to simplify our DH UI component mappings
since we no longer have the Spectrum dependency. This one addresses the
python modules + minimal re-mapping in the JS to make it still work. The
next one will cleanup the .js side more holistically.

* Removed components/spectrum subfolder and moved component modules to
parent
* Moved types into a components/types folder
* Minimal changes to SpectrumUtils to make mapping still work
* Added a broadstrokes e2e test to prove all components render

resolves #425
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 13, 2024
@bmingles
Refactored element mappings (deephaven#425)
0c43f6b
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 13, 2024
@bmingles
Deleted SpectrumElementUtils and fixed index (deephaven#425)
c938c6b
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 13, 2024
@bmingles
Delete unused function (deephaven#425)
b9eefca
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 13, 2024
@bmingles
Implicit <Text> wrapping of primitives (deephaven#425)
fd848d1
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jun 13, 2024
@bmingles
Updated e2e snapshots (deephaven#425)
85afa1f
@bmingles bmingles reopened this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
May 2024
3 participants
@bmingles @vbabich @mofojed