fix: deephaven-plugin-ui is compatible with deephaven-core 0.33.5 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jun 21, 2024
mofojed
commented
- We need to update the version so that you can install alongside deephaven-core 0.33.5
- We need to update the version so that you can install alongside deephaven-core 0.33.5
mattrunyon
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Something I noticed for local dev is this requirement makes it annoying when using the jetty server directly. You have to remember the --no-deps flag when installing the local wheel as the 0.35.0-SNAPSHOT doesn't seem to match this requirement, so pip goes and pulls it from pypi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.