Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home button needs left margin #1794

Closed
mattrunyon opened this issue Feb 12, 2024 · 0 comments · Fixed by #1951 or deephaven/deephaven-core#5406
Closed

Home button needs left margin #1794

mattrunyon opened this issue Feb 12, 2024 · 0 comments · Fixed by #1951 or deephaven/deephaven-core#5406
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@mattrunyon
Copy link
Collaborator

Description

When using multiple dashboards through dh.ui, the home button to return to code studio needs some left margin

image

Steps to reproduce

from deephaven import ui
from deephaven.plot import express as dx
from deephaven.plot.figure import Figure

_stocks = dx.data.stocks()
_cat_stocks = _stocks.where("sym=`CAT`")
_dog_stocks = _stocks.where("sym=`DOG`")
_stocks_plot = (
    Figure()
    .plot_xy("Cat", _cat_stocks, x="timestamp", y="price")
    .plot_xy("Dog", _dog_stocks, x="timestamp", y="price")
    .show()
)

my_dash = ui.dashboard(
    ui.column(
        ui.row(
            ui.stack(ui.panel(_cat_stocks, title="Cat")),
            ui.stack(ui.panel(_dog_stocks, title="Dog")),
        ),
        ui.stack(ui.panel(_stocks_plot, title="Stocks")),
    )
)
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Feb 12, 2024
@vbabich vbabich removed the triage Issue requires triage label Feb 13, 2024
@vbabich vbabich added this to the February 2024 milestone Feb 13, 2024
@vbabich vbabich added the good first issue Good for newcomers label Feb 13, 2024
@mofojed mofojed modified the milestones: February 2024, March 2024 Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
dsmmcken added a commit that referenced this issue Apr 20, 2024
Fixes #1794
- Label home as "vsTerminal Code Studio"
- Make it part of the navtab list to get an active state
- Allow navtab list to accept an Icon | JSX.Element
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Apr 24, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.74.0

# [0.74.0](deephaven/web-client-ui@v0.73.0...v0.74.0) (2024-04-24)

### Bug Fixes

* unable to select deselected leaf ([#1956](deephaven/web-client-ui#1956)) ([f5d622a](deephaven/web-client-ui@f5d622a)), closes [#1856](deephaven/web-client-ui#1856)


### Features

* Add DashboardPlugin support to embed-widget ([#1950](deephaven/web-client-ui#1950)) ([27fc8bd](deephaven/web-client-ui@27fc8bd))
* replace code studio home icon with "Code Studio" as label ([#1951](deephaven/web-client-ui#1951)) ([111ea64](deephaven/web-client-ui@111ea64)), closes [#1794](deephaven/web-client-ui#1794)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants